[sac-dev] inc/proto.h patch

[George Helffrich]

On Wednesday, November 30, 2005, at 04:29 PM, Brian Savage wrote:

> George
>
> Submitting patches works in this manner (As I see it).  If you have a 
> patch to contribute, send it to the mailing list. Create the patch 
> using  "diff -u ".  If the patch looks ok and is testing it ok, than 
> it can be committed.  I think only a few people have CVS write 
> premission (Peter for example).  The people with premission will 
> submit the patch, if you cannot.  Does this sound correct/reasonable ?

It sounds reasonable, but I don't see other patches or commits reviewed 
this way.  Is the process symmetric?

>
> Back to the patches:
>
> I understand the /sw/lib and /swinclude problem with the older 
> versions of OSX.  In that case, you solution will work fine.
>
> Concerning OSTYPE.
> Setting OSTYPE in bash and then exporting it does not work ?  I would 
> expect something like
> export OSTYPE=darwin6
> to set this variable in subordinate shells.  Correct me if I am wrong.
> I would also look info MAKEFLAGS to see if it is available/appropriate.

Please, let's not debate *user* workarounds to the build problem; I am, 
um, moderately conversant with the shell and know how to surmount the 
issue in comparable ways to what you propose.  What the patch aims to 
do -- and does -- is to make the build work out of the box for the 
impatient and uninitiated builder.  This is the environment and OSTYPE 
value that OSX 10.2 presents to that user, and, I think, the spirit of 
the readme text.

I will try to commit the include patch and wait on a verdict on the 
makefile one.  Then, hopefully, we can move discussion to development 
issues rather than lessons on shell use.  Please?

                                                                         
      George Helffrich